Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libp2p examples #1735

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Fix libp2p examples #1735

merged 10 commits into from
Sep 19, 2023

Conversation

rob-maron
Copy link
Collaborator

aims to close #1545

@rob-maron rob-maron marked this pull request as ready for review September 13, 2023 17:16
@rob-maron rob-maron marked this pull request as draft September 13, 2023 17:23
@rob-maron rob-maron marked this pull request as ready for review September 13, 2023 17:53
DieracDelta
DieracDelta previously approved these changes Sep 17, 2023
Copy link
Contributor

@DieracDelta DieracDelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this LGTM!

crates/hotshot/examples/infra/modDA.rs Outdated Show resolved Hide resolved
DieracDelta
DieracDelta previously approved these changes Sep 18, 2023
DieracDelta
DieracDelta previously approved these changes Sep 18, 2023
@elliedavidson
Copy link
Member

Let's merge this today so we can start benching, and make issues for anything outstanding.

@rob-maron rob-maron merged commit 8ba6084 into main Sep 19, 2023
6 checks passed
@rob-maron rob-maron deleted the rm/fix-libp2p-examples branch September 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples to work with libp2p
3 participants