Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PROPOSAL and VOTE generics from CommunicationChannel; Add COMMITTABLE generic to VoteType #1723

Closed
wants to merge 8 commits into from

Conversation

elliedavidson
Copy link
Member

@elliedavidson elliedavidson commented Sep 12, 2023

This PR:

  • Removes PROPOSAL and VOTE generics from the CommunicationChannel trait
  • Adds COMMITTABLE generic to VoteType, since each vote needs to be over a specific committable type
  • Adds placeholder Accumulator2 code for the new accumulator that will be certificate-based instead of exchange based.

NOTE: There are still TODO ED notes in the code. We can merge this in now to get the above changes in, or we can wait until I finish the accumulator logic. I don't mind either way.

@elliedavidson elliedavidson requested review from shenkeyao, bfish713 and rob-maron and removed request for shenkeyao September 12, 2023 22:51
@elliedavidson elliedavidson deleted the ed/vote-accumulator branch September 12, 2023 23:25
@elliedavidson elliedavidson restored the ed/vote-accumulator branch September 12, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant