Replace block building with block payload #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliedavidson
previously approved these changes
Sep 12, 2023
crates/hotshot/src/demos/sdemo.rs
Outdated
| @@ -229,6 +234,13 @@ impl Block for SDemoBlock { | |||
| .collect(), | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Such cleanliness! Thank you!
bfish713
previously approved these changes
Sep 14, 2023
elliedavidson
previously approved these changes
Sep 14, 2023
shenkeyao
dismissed stale reviews from elliedavidson and bfish713
via
40bc007
ggutoski
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing the current block-building API as planned in #1672, this PR renames
BlocktoBlockPayloadwith an additional unimplementedcommitfunction.This allows us to be ready to implement the block payload and header without breaking the build, and we can add the VID commitment computation once the VID integration is in.
Closes #1672. Also is part 1 of #1673 (part 2 is in progress).