Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audit.toml to remove RUSTSEC-2022-0093 ignore #1577

Closed
wants to merge 1 commit into from

Conversation

elliedavidson
Copy link
Member

@elliedavidson elliedavidson commented Aug 18, 2023

The issue tracking this audit finding in libp2p has been closed. libp2p/rust-libp2p#4327

We can merge this once we update libp2p

@elliedavidson elliedavidson changed the title remove audit ignore Update audit.toml to remove RUSTSEC-2022-0093 ignore Aug 18, 2023
@DieracDelta
Copy link
Contributor

DieracDelta commented Aug 18, 2023

Updating libp2p-identity doesn't pass the audit. I think we need to wait for libp2p to make a new release. Also tide-disco depends on the markdown crate which is unmaintained. I think we may need to fix that as well to get the security audit to pass.

@elliedavidson
Copy link
Member Author

The markdown issue is just a warning. Audit will pass with it.

Yes, it looks like we'll need to resolve some Jellyfish conflicts first before we are able to update libp2p-identity. Here's an issue for this: #1578

@elliedavidson
Copy link
Member Author

This will probably be partially resolved once we remove the dependency on hotshot-primitives crate

@elliedavidson elliedavidson deleted the ed/update-rustsec branch September 5, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants