Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for Consensus #1565

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Unit Tests for Consensus #1565

merged 18 commits into from
Aug 22, 2023

Conversation

bfish713
Copy link
Collaborator

@bfish713 bfish713 commented Aug 15, 2023

Adds very basic tests for the consensus task. Tests that a node can send a proposal and vote after receiving a propsal.

This is a good base to build more complex test off of. We still need code for creating some other events, like DAC but adding tests should go much faster starting from this point

closes: #1492

@bfish713 bfish713 marked this pull request as ready for review August 18, 2023 15:42
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only nit comments about tracing.

task-impls/src/consensus.rs Outdated Show resolved Hide resolved
task-impls/src/consensus.rs Show resolved Hide resolved
task-impls/src/harness.rs Outdated Show resolved Hide resolved
testing/tests/consensus_task.rs Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
DieracDelta
DieracDelta previously approved these changes Aug 21, 2023
task-impls/src/harness.rs Outdated Show resolved Hide resolved
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bfish713 bfish713 merged commit 5577393 into main Aug 22, 2023
6 of 7 checks passed
@Ancient123 Ancient123 deleted the bf/consensus-unit-tests branch October 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests for Consensus
3 participants