Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run view refactor #1250

Merged
merged 521 commits into from
Aug 4, 2023
Merged

Run view refactor #1250

merged 521 commits into from
Aug 4, 2023

Conversation

DieracDelta
Copy link
Contributor

@DieracDelta DieracDelta commented Jun 6, 2023 •
edited by shenkeyao
Loading

Merge run view refactor into main.

Closes #1418.

@DieracDelta DieracDelta marked this pull request as draft June 6, 2023 14:44
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

elliedavidson and others added 28 commits July 8, 2023 18:12
@elliedavidson
Add logic in consensus task to account for genesis DAC
7d9f50b
@elliedavidson
Added per network task exchange filters
cf4eb58
@elliedavidson
Nodes are properly sending first quorum proposal, receiving it, and v…
452a2b2 
…oting on it
@elliedavidson
Before trying to start consensus on view 1
31f7dc5
@elliedavidson
quorum leader is forming a certificate, then test hangs
912e0d5
@elliedavidson
Need to think about how to properly update view number
25d00e0
@elliedavidson
Test runs for 75 views, unclear if the logic is correct
b701525
@elliedavidson
Proposal's parent missing from storage on view 2
826dd6e
@elliedavidson
Need to update vot_if_able to vote over correct leaf commitment
be6d379
@elliedavidson
Consensus task appears to be workign thus far, now need to get DA tas…
d605db5 
…k working so replicas can receive vote with DACs
@elliedavidson
DA members are sending votes to DA leader
b6d3e06
@elliedavidson
Add DAC handling to network task, onto error where DACs are invalid w…
26810cc 
…hen replicas check them
@elliedavidson
Debugging race conditions
591359e
@elliedavidson
More logging
a563b72
@elliedavidson
Update self.block
c87a27e
@elliedavidson
logging improvements
5ecc17f
@shenkeyao
Merge pull request #1354 from EspressoSystems/keyao/remove-nll-todo
2bda686 
Fix shutdown call, modify consensus state construction, and remove todos
@elliedavidson
Address comments
1aa598d
@DieracDelta
feat: tests of channel stream
354d212
@elliedavidson
Merge pull request #1364 from EspressoSystems/jr/more_tests
119e7cb 
More tests
@elliedavidson
Merge pull request #1357 from EspressoSystems/ed/run_view_debugging
9567a26 
Debugging
@elliedavidson
Fix duplicate votes!
ec17120
@shenkeyao
Update handle_message and event filters for network task
bbc77bb
@shenkeyao
Fix add_network_task calls
5cf1cf0
@bfish713
updated locked view and send decide event
e6ab62e
@elliedavidson
Off by 1 debugging
27c0ac0
@shenkeyao
Fix build
95300e9
@elliedavidson
Fix off by 1 error in network task
5652630
alxiong and others added 16 commits August 3, 2023 01:48
@alxiong
move QC circuit
ba9a42b
@shenkeyao
Merge branch 'run_view_refactor' into keyao/fix-lints
7514d3e
@shenkeyao
Fix lints after merging
ed40830
@shenkeyao
Fix DA task to handle TransactionsRecv
245cb60
@DieracDelta
Merge pull request #1291 from EspressoSystems/jr/upgrade_libp2p
6bd2657 
Bump libp2p
@shenkeyao
Merge pull request #1479 from EspressoSystems/keyao/fix-lints
e212b13 
Fix lints
@alxiong
Merge remote-tracking branch 'origin/run_view_refactor' into alex/hs-…
76ac0b1 
…primitives
@alxiong
fix: clippy err
a74a2d1
@alxiong
chore: remove full-ci feature
05b208d
@bfish713
Merge branch 'run_view_refactor' into bf/no-duplicate-transactions
c415577
@shenkeyao
Merge branch 'main' into keyao/merge
e522139
@shenkeyao
Add missed files
8a242bf
@alxiong
Merge pull request #1480 from EspressoSystems/alex/hs-primitives
88293ea 
feat: move in QC and stake table traits and impl from hotshot-primitives
@bfish713
Merge pull request #1449 from EspressoSystems/bf/no-duplicate-transac…
a946c76 
…tions

Discard Seen Transactions
@shenkeyao
Merge branch 'run_view_refactor' into keyao/merge
112e16b
@shenkeyao
Merge pull request #1485 from EspressoSystems/keyao/merge
165c30f 
Sync with main
@shenkeyao shenkeyao marked this pull request as ready for review August 4, 2023 16:10
elliedavidson
elliedavidson previously approved these changes Aug 4, 2023
View reviewed changes
@elliedavidson elliedavidson self-requested a review August 4, 2023 21:02
@shenkeyao shenkeyao merged commit ad1acfe into main Aug 4, 2023
6 of 8 checks passed
@shenkeyao shenkeyao deleted the run_view_refactor branch August 4, 2023 21:03
@elliedavidson elliedavidson restored the run_view_refactor branch August 4, 2023 21:03
@Ancient123 Ancient123 deleted the run_view_refactor branch October 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliedavidson elliedavidson elliedavidson approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@kmchicoine kmchicoine Awaiting requested review from kmchicoine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge run_view_refactor into main and fix lints
9 participants
@DieracDelta @CLAassistant @elliedavidson @shenkeyao @bfish713 @kmchicoine @dailinsubjam @jbearer @alxiong