Fix lint bug

EspressoSystems · Sep 22, 2023 · bb0eb5f · bb0eb5f
1 parent c248d2e
commit bb0eb5f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/crates/task-impls/src/consensus.rs b/crates/task-impls/src/consensus.rs
@@ -673,9 +673,13 @@ where
                         return;
                     };
 
+                    if timeout_cert.view_number != view - 1 {
+                        warn!("Timeout certificate for view {} was not for the immediately preceding view", *view);
+                    }
+
                     if !self
                         .timeout_exchange
-                        .is_valid_cert(&timeout_cert.clone(), view.commit())
+                        .is_valid_cert(&timeout_cert.clone(), timeout_cert.view_number.commit())
                     {
                         warn!("Timeout certificate for view {} was invalid", *view);
                         return;

diff --git a/crates/task-impls/src/da.rs b/crates/task-impls/src/da.rs
@@ -159,7 +159,6 @@ where
                 &vote.block_commitment,
             ) {
                 Left(new_accumulator) => {
-                    error!("Not enough DA votes yet");
                     state.accumulator = either::Left(new_accumulator);
                 }
 

diff --git a/crates/task-impls/src/network.rs b/crates/task-impls/src/network.rs
@@ -99,10 +99,6 @@ impl<
                         },
                         Either::Right(committee_message) => match committee_message {
                             CommitteeConsensusMessage::DAProposal(proposal) => {
-                                error!(
-                                    "Received da proposal for view {:?}",
-                                    proposal.clone().data.view_number
-                                );
                                 SequencingHotShotEvent::DAProposalRecv(proposal.clone(), sender)
                             }
                             CommitteeConsensusMessage::DAVote(vote) => {

diff --git a/crates/types/src/traits/election.rs b/crates/types/src/traits/election.rs
@@ -329,7 +329,10 @@ pub trait ConsensusExchange<TYPES: NodeType, M: NetworkMsg>: Send + Sync {
         let leaf_commitment = qc.leaf_commitment();
 
         if leaf_commitment != commit {
-            error!("Leaf commitment does not equal parent commitment");
+            error!(
+                "Leaf commitment does not equal parent commitment {:?}",
+                qc.signatures()
+            );
             return false;
         }