log emit view change earlier

EspressoSystems · Oct 24, 2024 · 7e3db10 · 7e3db10
1 parent 8b3ad20
commit 7e3db10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/crates/task-impls/src/quorum_proposal_recv/handlers.rs b/crates/task-impls/src/quorum_proposal_recv/handlers.rs
@@ -141,7 +141,11 @@ pub(crate) async fn handle_quorum_proposal_recv<
         consensus.metrics.invalid_qc.update(1);
         bail!("Invalid justify_qc in proposal for view {}", *view_number);
     }
-
+    broadcast_event(
+        Arc::new(HotShotEvent::ViewChange(view_number + 1)),
+        event_sender,
+    )
+    .await;
     broadcast_event(
         Arc::new(HotShotEvent::QuorumProposalPreliminarilyValidated(
             proposal.clone(),
@@ -221,11 +225,7 @@ pub(crate) async fn handle_quorum_proposal_recv<
             justify_qc.data.leaf_commit
         );
         validate_proposal_liveness(proposal, event_sender, &task_state).await?;
-        broadcast_event(
-            Arc::new(HotShotEvent::ViewChange(view_number + 1)),
-            event_sender,
-        )
-        .await;
+
         return Ok(());
     };
 
@@ -238,11 +238,6 @@ pub(crate) async fn handle_quorum_proposal_recv<
         quorum_proposal_sender_key,
     )
     .await?;
-    broadcast_event(
-        Arc::new(HotShotEvent::ViewChange(view_number + 1)),
-        event_sender,
-    )
-    .await;
 
     Ok(())
 }
diff --git a/crates/task-impls/src/quorum_proposal_recv/mod.rs b/crates/task-impls/src/quorum_proposal_recv/mod.rs
@@ -136,6 +136,7 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions>
                 if self.consensus.read().await.cur_view() > proposal.data.view_number()
                     || self.cur_view > proposal.data.view_number()
                 {
+                    tracing::error!("Throwing away old proposal");
                     return;
                 }
                 let validation_info = ValidationInfo::<TYPES, I, V> {