Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: more detailed benchmarking #86

Closed
wants to merge 5 commits into from
Closed

perf: more detailed benchmarking #86

wants to merge 5 commits into from

Conversation

avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Aug 28, 2024

Base automatically changed from ap/buildkite to main September 3, 2024 12:31
@avik-pal avik-pal force-pushed the ap/bench2 branch 4 times, most recently from 732663d to 56cac38 Compare September 3, 2024 13:50
@avik-pal avik-pal force-pushed the ap/bench2 branch 2 times, most recently from 2e50132 to 7017ac9 Compare September 14, 2024 23:45
@avik-pal avik-pal changed the base branch from main to ap/concat September 14, 2024 23:45
Base automatically changed from ap/concat to main September 15, 2024 00:11
@avik-pal
Copy link
Collaborator Author

Some of the more complicated models are blocked by:

  1. Compiling leads to KeyError #107 -- prevents models carrying over state information (any normalization layers) from being compiled
  2. Mixer models are blocked by Grouped Convolution generates incorrect code #106

Copy link
Contributor

Benchmark Results (ASV)

main a0c6198... main/a0c61981d24d1b...
comptime/basics/2D sum 25.7 ± 0.85 ms 27.5 ± 0.75 ms 0.936
comptime/basics/Basic cos 24.9 ± 1.2 ms 25.7 ± 0.82 ms 0.97
comptime/basics/Basic grad cos 0.0434 ± 0.0018 s 0.0448 ± 0.0006 s 0.968
comptime/lux neural networks/vgg11 0.406 ± 0.0048 s 0.406 ± 0.017 s 1
comptime/lux neural networks/vgg13 0.442 ± 0.023 s 0.455 ± 0.011 s 0.972
comptime/lux neural networks/vgg16 0.542 ± 0.0079 s 0.56 ± 0.013 s 0.967
comptime/lux neural networks/vgg19 0.631 ± 0.023 s 0.615 ± 0.019 s 1.03
time_to_load 1.29 ± 0.023 s 1.3 ± 0.0067 s 0.991

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal
Copy link
Collaborator Author

avik-pal commented Oct 1, 2024

Too much conflict. I will open a new PR based off of #130

@avik-pal avik-pal closed this Oct 1, 2024
@avik-pal avik-pal deleted the ap/bench2 branch October 1, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant