chore: bump ReactantCore version #270
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
reviewed
Nov 12, 2024
| @@ -39,7 +39,7 @@ LinearAlgebra = "1.10" | |||
| NNlib = "0.9" | |||
| OrderedCollections = "1" | |||
| Preferences = "1.4" | |||
| ReactantCore = "0.1.1" | |||
| ReactantCore = "0.1.2" | |||
There was a problem hiding this comment.
Do we really need to fix the patch version? shouldn't just putting 0.1 work?
There was a problem hiding this comment.
it relies on ReactantCore.traced_while which is not defined on 0.1
There was a problem hiding this comment.
ideally we setup https://discourse.julialang.org/t/psa-add-downgrade-ci-to-better-check-version-compatibility/110063. It ensures that minimum versions are always in an installable state
There was a problem hiding this comment.
uh I always wondered if sth like this was actually easily doable
would you mind opening an issue for this? I can do it some other day
avik-pal
force-pushed
the
ap/fix_install
branch
from
cfdce2a
to
8b39414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep these in-sync for new functionality