feat: overload mul!
#230
Merged
feat: overload mul!
#230
+94
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Nov 6, 2024
| @nospecialize(C::TracedRArray{T1,2}), | ||
| @nospecialize(A::TracedRArray{T2,2}), | ||
| @nospecialize(B::TracedRArray{T3,2}), | ||
| ) where {T1,T2,T3} |
There was a problem hiding this comment.
Is it worth overriding the version with alpha and beta?
There was a problem hiding this comment.
yeah we need to add that, else it does the for loop
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wsmoses
reviewed
Nov 6, 2024
avik-pal
force-pushed
the
ap/inplace_mul!
branch
from
835af61
to
54c7897
Compare
wsmoses
reviewed
Nov 6, 2024
src/TracedRArray.jl
Outdated
| if isone(α) | ||
| C.mlir_data = res | ||
| else | ||
| C.mlir_data = (TracedRArray{T1,2}((), res, size(C)) .* α).mlir_data |
There was a problem hiding this comment.
doing a broadcast here probably won't optimize well for now (or rather we need to write optimizations on the batch op. Being able to driectly emit the elementwise mul of a broadcast will likely be a nontrivial perf win as a result
wsmoses
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses LuxDL/Lux.jl#1025