Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_cn localization for Tooltips and JEI descriptions #5430

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

ZZZank
Copy link
Contributor

@ZZZank ZZZank commented Dec 1, 2023

This PR adds full zh_cn localization for Tooltips and JEI descriptions, which are made localizable in #5426 and #5423 .

Crowdin?

I do know about Crowdin(actually I'm a Crowdin user myself), but by the time I write down this line, E6E on Crowdin is not updated yet.
Also, Crowdin does not support upload .json transaltion file, so it will cause more trouble than convinence if I need to manually copy every line and submit it individually.

Localization quality?

My mother tongue is Chinese. And based on my own experience, I can say my translation is in 'good, occationally awesome' level.
But it will still be great to find someone else to verify these translations. It will always be helpful.

@NielsPilgaard
Copy link
Collaborator

Thank you 😊

@NielsPilgaard NielsPilgaard merged commit ecd3efd into EnigmaticaModpacks:develop Dec 1, 2023
5 of 7 checks passed
@ZZZank ZZZank deleted the to_be_zhcn branch December 5, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants