Re-enable buffering #2618
Merged
Re-enable buffering #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for masks to work properly.
me4502
approved these changes
Sep 6, 2024
me4502
reviewed
Sep 6, 2024
| @@ -618,10 +621,12 @@ public void setBatchingChunks(boolean batchingChunks) { | |||
| } | |||
| return; | |||
| } | |||
| assert batchingExtent != null : "same nullness as chunkBatchingExtent"; | |||
There was a problem hiding this comment.
so i don't necessarily have issue with assert statements, but i don't believe we really use these anywhere else?
There was a problem hiding this comment.
I don't know if I've needed these elsewhere, it was just to shut IntelliJ up about null checks.
There was a problem hiding this comment.
That is -- this is purely informational for the reader and the IDE, not meant to be run.
octylFractal
deleted the
ot/fix/restore-buffering-for-masks-must-not-see-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for masks to work properly.