Use Bukkit Registry API where possible #2573
Merged
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
force-pushed
the
chore/use-bukkit-registry-api
branch
from
ad72e46
to
3fc4b2f
Compare
octylFractal
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR functionally makes no changes (other than being able to remove the EntityType.UNKNOWN workaround), but will prepare us better for when Spigot drop the enums. We'll still have to split the material iterator out into ItemType/BlockType, but we'll automatically benefit from changes such as custom biome support.
This should also fix
Material.values()-related issues when Commodore is disabled, although it won't run without it on Paper anyway due to remapping.