Improve ArbitraryShape caching #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2325 +/- ##
========================================
Coverage 8.88% 8.89%
Complexity 1095 1095
========================================
Files 886 886
Lines 46452 46443 -9
Branches 5189 5187 -2
========================================
Hits 4129 4129
+ Misses 42130 42121 -9
Partials 193 193
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
me4502
reviewed
May 27, 2023
worldedit-core/src/main/java/com/sk89q/worldedit/regions/shape/ArbitraryShape.java
Outdated
Show resolved
Hide resolved
TomyLobo
force-pushed
the
improve-arbitraryshape-caching
branch
4 times, most recently
from
be2e038
to
7a5abee
Compare
|
Out of curiosity how does this impact command durations? Even just a before & after command time elapsed with the |
me4502
approved these changes
Jun 7, 2023
Every point is now only evaluated once.
me4502
force-pushed
the
improve-arbitraryshape-caching
branch
from
4a0d3ed
to
dae319d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every point is now only evaluated once.