Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Design & Misc #68

Merged
merged 18 commits into from
Aug 11, 2023
Merged

Fix: Design & Misc #68

merged 18 commits into from
Aug 11, 2023

Conversation

MinixBF
Copy link
Contributor

@MinixBF MinixBF commented Aug 3, 2023

  • Fix the size of the button zone to go up in the footer
  • Fix chevron smaller
  • Add color scheme to dark (meta and CSS)

Additional changes (Antoine edit)

  • "Truly" fix chevron size getting reduced on responsive
  • Get rid of all in-Svelte CSS, by using in-markup Tailwind and moving global stuff to the base Tailwind's layer
  • Use the .vscode folder to use project-scoped and shared settings:
    • Use tailwind.json to tell VSCode what @apply and others are, removing the yellow underline (see Unknown at rule @apply css(unknownAtRules) tailwindlabs/tailwindcss#5258 (comment))
    • Override (I wish I could simply extend them) Tailwind VSCode plugin classes config, allowing "hover support" on class names for custom directives (enter, enterFrom, enterTo, leave, leaveFrom & leaveTo) in SlideOver.svelte, which uses TailwindUI
  • Add Svelte 4 type safety to createEventDispatchers, allowing safer use of custom dispatches (should've been done in Migrate to Svelte 4 #19)
  • Localize +error.svelte (should've been done in Localization #14)
  • Fix SlideOver.svelte not animating (I don't know since when it's been broken)
  • Run prettier manually with pnpx prettier --write --plugin prettier-plugin-svelte --plugin prettier-plugin-tailwindcss ., as external plugins are broken with Prettier 3 for now

Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorter than I imagined 😂

src/app.css Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/+layout.svelte Outdated Show resolved Hide resolved
@WarningImHack3r WarningImHack3r changed the title Fix : Design Fix: Design Aug 3, 2023
@WarningImHack3r WarningImHack3r self-assigned this Aug 7, 2023
@WarningImHack3r WarningImHack3r changed the title Fix: Design Fix: Design & Misc Aug 11, 2023
@MinixBF
Copy link
Contributor Author

MinixBF commented Aug 11, 2023

Approved 👍🏻
Verry easy to implement tailwind layer

Can't wait to see the fixed on the chevron if it'll be enough 😉

@WarningImHack3r
Copy link
Member

Very easy to implement tailwind layer

Yes, you see!

Can't wait to see the fixed on the chevron if it'll be enough 😉

It will!! I tested on all sizes

@WarningImHack3r WarningImHack3r merged commit 5b5446f into main Aug 11, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the fix-design branch August 11, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants