Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation & links #102

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Navigation & links #102

merged 8 commits into from
Sep 4, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented Sep 2, 2023

Changes we talked about in my comment in #97.

Changes made

Navigation bar

  • Add missing links in the navigation bar
  • Remove contact from the navbarItems as it does not belong here and is never used in the markup anyway
  • Navigation bar items:
    • Use goto if the link starts with / (should cover 100% of the cases), else keep scrollTo
    • Add support for "active" links that can't be clicked onto, to replace usual links with static underlined labels if they point to the current displayed page. They should be future-proof and work out of the box.

Footer

  • Remove the Legal part (not needed)
  • Make links clickable only if their target is not .
    • Change "default target" to . instead of / (because we have a link to Home)
  • Rework logic to improve responsiveness, get rid of tailwindXlScreen in JS, and reduce the usage of tailwindXsScreen
  • Fix the scroll-to-top button getting overlapped by Emerald Studio on some specific screen sizes (regression from Rebranding #18?)

Other

  • Add type="button" to all <button>s
  • Comment out buttons that are not used yet in /
  • Add comments

@MinixBF
Copy link
Contributor

MinixBF commented Sep 3, 2023

Points to discuss :
We need to add dropdowns in the navbar to navigate. (solutions, company)

Legal

No need, we can remove it

Footer links
What do we do with the footer items links for now? All of them will be linked to pages that don't yet exist, so we can't do much about them for now. My idea: keep them as-is but make them non-clickable if their href is /. As no footer link will ever link to /, I think it can do the trick. However, we will likely have to remove this condition entirely once all the links are made.

Make them non-clickable and after going to the next step, write the blog section with markdown files. Let's move to another PR
For the pages in the "Solutions" section and others "See more" button

"See more" buttons
In that same idea of not leaving any clickable element "not done", we will have to comment/remove temporarily all buttons in the pages that are not bound yet to a future page. Do we also do that in this PR?

I have comment button see more #97

@WarningImHack3r
Copy link
Member Author

We need to add dropdowns in the navbar to navigate. (solutions, company)

Yes, we do! But I feel like it's not something we have to do right now, it's fine enough to wait and make it the "navbar 2.0"

No need, we can remove it

On its way

Make them non-clickable

On its way too

I have comment button see more #97

Ok but:

  • What about the other "See more" buttons all across the page? Do we comment them (in this PR)? Remove them?
  • Depending on your answer, do we "move" your comment in About us section #97 in this PR instead so we do all of them in the same place?

- Remove the legal section & localization
- Make footer items clickable only if the target is not "."

Also:
- Rework footer layout for more flexibility and better code, getting rid
 of a Tailwind screen in JS
- Reduce usage of in-JS Tailwind screen in favor of CSS solutions
- Fix scroll-to-top button getting overlapped
- Add type="button" to all standard buttons
@WarningImHack3r
Copy link
Member Author

Updated PR's description after changes + discussion

@MinixBF
Copy link
Contributor

MinixBF commented Sep 3, 2023

I think we can only comment here, just because the next step is to uncomment and add the page link to them.

@WarningImHack3r
Copy link
Member Author

Ok so let's keep your commenting on #97, and we will comment the rest of those buttons in this PR (if that's what you mean)!

@WarningImHack3r WarningImHack3r marked this pull request as ready for review September 4, 2023 22:05
@WarningImHack3r WarningImHack3r merged commit 299df97 into main Sep 4, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the navbar-and-links branch September 4, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants