-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation & links #102
Navigation & links #102
Conversation
Points to discuss :
No need, we can remove it
Make them non-clickable and after going to the next step, write the blog section with markdown files. Let's move to another PR
I have comment button see more #97 |
Yes, we do! But I feel like it's not something we have to do right now, it's fine enough to wait and make it the "navbar 2.0"
On its way
On its way too
Ok but:
|
- Remove the legal section & localization - Make footer items clickable only if the target is not "." Also: - Rework footer layout for more flexibility and better code, getting rid of a Tailwind screen in JS - Reduce usage of in-JS Tailwind screen in favor of CSS solutions - Fix scroll-to-top button getting overlapped - Add type="button" to all standard buttons
Updated PR's description after changes + discussion |
I think we can only comment here, just because the next step is to uncomment and add the page link to them. |
Ok so let's keep your commenting on #97, and we will comment the rest of those buttons in this PR (if that's what you mean)! |
Changes we talked about in my comment in #97.
Changes made
Navigation bar
contact
from thenavbarItems
as it does not belong here and is never used in the markup anywaygoto
if the link starts with/
(should cover 100% of the cases), else keepscrollTo
Footer
.
.
instead of/
(because we have a link to Home)tailwindXlScreen
in JS, and reduce the usage oftailwindXsScreen
Emerald Studio
on some specific screen sizes (regression from Rebranding #18?)Other
type="button"
to all<button>
s/