Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][BR001549][MIG] project_project_category: Migration to 12.0 #237

Open
wants to merge 8 commits into
base: 12.0
Choose a base branch
from
Open

[12.0][BR001549][MIG] project_project_category: Migration to 12.0 #237

wants to merge 8 commits into from

Conversation

Reinhard-sheng
Copy link

@Elico-Corp/odoo-reviewers

elicoidal
elicoidal requested changes Mar 25, 2019
View reviewed changes
project_project_category/README.rst Outdated
@@ -0,0 +1,60 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

png

project_project_category/README.rst Outdated
@@ -0,0 +1,60 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to LGPL too

project_project_category/README.rst Outdated

This module extends the functionality of Project to add a category on the project itself, also support search filter and group by.

Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section

project_project_category/README.rst Outdated
Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/Elico-Corp/elico_odoo/issues>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odoo-addons

project_project_category/__manifest__.py Outdated
'website': 'https://www.elico-corp.com',
'support': '[email protected]',
"author": "Elico corp",
"license": "AGPL-3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGPL

project_project_category/data/project_project_category_data.xml Outdated Show resolved Hide resolved
project_project_category/__manifest__.py Outdated
@@ -0,0 +1,23 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no coding in v12

project_project_category/data/project_project_category_data.xml Outdated
</record>

</data>
</odoo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line

project_project_category/models/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# © 2016-2017 Elico Corp (https://www.elico-corp.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016-2019 (everywhere)

project_project_category/views/project_project_view.xml Outdated
<field name="project_categ_id"/>
</field>
<group expand="0" string="Group By">
<filter name ="project_category" string="Project category" domain="[]" context="{'group_by': 'project_categ_id'}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve readability

@Reinhard-sheng
Copy link
Author

Updated

elicoidal
elicoidal reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

project_project_category/data/project_project_category_data.xml Outdated

<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data noupdate="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove data key and merge with odoo

project_project_category/data/project_project_category_data.xml Outdated
@@ -0,0 +1,25 @@
<!-- -*- coding: utf-8 -*- -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no coding in XML

@Reinhard-sheng
Copy link
Author

Updated again.

elicoidal
elicoidal approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waiting for Travis

@elicoidal
Copy link
Contributor

Please check travis

JoJoJoJoJoJoJo
JoJoJoJoJoJoJo reviewed Mar 25, 2019
View reviewed changes
Copy link

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details.

project_project_category/models/project_project_category.py Outdated
class ProjectProjectCategory(models.Model):
_name = 'project.project.category'

name = fields.Char('Name', required=True, translate=True, select=True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = fields.Char('Name', required=True, translate=True, select=True)
name = fields.Char('Name', required=True, translate=True, index=True)

select is deprecated.

project_project_category/models/__init__.py Outdated
@@ -0,0 +1,4 @@
# © 2016-2019 Elico Corp (https://www.elico-corp.com)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License not needed in __init__.py

project_project_category/__init__.py Outdated
@@ -0,0 +1,4 @@
# © 2016-2019 Elico Corp (https://www.elico-corp.com)
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No license here.

project_project_category/models/project_project_category.py Outdated
# © 2016-2019 Elico Corp (https://www.elico-corp.com)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from openerp import fields, models
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from openerp import fields, models
from odoo import fields, models

@Reinhard-sheng Reinhard-sheng changed the title [MIG] project_project_category: Migration to 12.0 [12.0][BR001549][MIG] project_project_category: Migration to 12.0 Mar 26, 2019
JoJoJoJoJoJoJo
JoJoJoJoJoJoJo approved these changes Mar 27, 2019
View reviewed changes
Copy link

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elicoidal
elicoidal approved these changes Mar 27, 2019
View reviewed changes
project_project_category/models/project_project_category.py
class ProjectProjectCategory(models.Model):
_name = 'project.project.category'

name = fields.Char('Name', required=True, translate=True, index=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need the strings

@elicoidal
Copy link
Contributor

Travis is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo JoJoJoJoJoJoJo approved these changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Reinhard-sheng @elicoidal @JoJoJoJoJoJoJo