avoid timeout errors with high concurrency in api_model #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrawins
requested review from
haileyschoelkopf,
lintangsutawika and
baberabb
as code owners
|
|
|
Thanks v. much for the PR. left a comment. Also cc: @artemorloff, as he had also made the change in #2249. |
baberabb
reviewed
Sep 26, 2024
| @@ -433,7 +433,9 @@ async def get_batched_requests( | |||
| ) -> Union[List[List[str]], List[List[Tuple[float, bool]]]]: | |||
| ctxlens = ctxlens if ctxlens else [None] * len(requests) | |||
| conn = TCPConnector(limit=self._concurrent) | |||
| async with ClientSession(connector=conn) as session: | |||
| async with ClientSession( | |||
| connector=conn, timeout=ClientTimeout(total=6 * 60 * 60) | |||
There was a problem hiding this comment.
Can we add this to the class constructor, so that's it configurable?
|
sorry @dtrawins . Forgot to commit the review message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longer timeout will avoid errors when running tests with high concurrency