Add environment and transformers version logging in results dump #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to help researchers track inconsistencies
LSinev
requested review from
haileyschoelkopf and
lintangsutawika
as code owners
|
Thank you very much for this PR! Adding these to logging_utils would be a good idea! |
|
moved added functions to logging_utils |
|
Thank you for the contribution @LSinev ! |
haileyschoelkopf
approved these changes
Feb 24, 2024
wx-zhang
pushed a commit
to wx-zhang/lm-evaluation-harness
that referenced
this pull request
Mar 13, 2024
…utherAI#1464) * Save git_hash to results even if git is not available to call as subprocess * Store more info about environment and transformers version in results to help researchers track inconsistencies * moved added logging to logging_utils * moved get_git_commit_hash to logging_utils.py * moved add_env_info inside evaluator
nightingal3
pushed a commit
to mycoalchen/lm-evaluation-harness
that referenced
this pull request
May 2, 2024
…utherAI#1464) * Save git_hash to results even if git is not available to call as subprocess * Store more info about environment and transformers version in results to help researchers track inconsistencies * moved added logging to logging_utils * moved get_git_commit_hash to logging_utils.py * moved add_env_info inside evaluator
djstrong
pushed a commit
to speakleash/lm-evaluation-harness
that referenced
this pull request
Aug 2, 2024
…utherAI#1464) * Save git_hash to results even if git is not available to call as subprocess * Store more info about environment and transformers version in results to help researchers track inconsistencies * moved added logging to logging_utils * moved get_git_commit_hash to logging_utils.py * moved add_env_info inside evaluator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help researchers detect inconsistencies caused by different versions of drivers or packages:
Was not sure where to place functions. Seems that all of these can be moved to
logging_utilsif it is not wandb only.