Log which subtasks were called with which groups #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintangsutawika
approved these changes
Feb 22, 2024
wx-zhang
pushed a commit
to wx-zhang/lm-evaluation-harness
that referenced
this pull request
Mar 13, 2024
* log group membership * no stray prints * Update evaluator.py
nightingal3
pushed a commit
to mycoalchen/lm-evaluation-harness
that referenced
this pull request
May 2, 2024
* log group membership * no stray prints * Update evaluator.py
djstrong
pushed a commit
to speakleash/lm-evaluation-harness
that referenced
this pull request
Aug 2, 2024
* log group membership * no stray prints * Update evaluator.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging to
results.jsonlof what subtasks belonged to which groups when they were called, as requested by @Sparkier !I am not sure if the name for this attribute is self-explanatory enough or if there is perhaps a better one.
We will need to ensure addressing #1436 doesn't break this.