[Refactor] Openai completions #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation-harness into openai_completions
lintangsutawika
requested review from
haileyschoelkopf and
StellaAthena
as code owners
aidansan
reviewed
Nov 27, 2023
haileyschoelkopf
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Approving, although noting that @lintangsutawika flagged that
the chat version of the model tends to over-explain so it fails on our current settings without additional filters
We may want to support variants of tasks which are more tailored for verbose CoT-using models, down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@haileyschoelkopf Openai's api that returns logits will be retired on Jan 4 2024 so it probably doesn't make much sense to continue to support it. Which means the only api available will be the chat completions.