Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKTP-795 #1

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

MKTP-795 #1

wants to merge 22 commits into from

Conversation

alexminza
Copy link
Member

@alexminza alexminza commented Oct 15, 2022

What is the purpose of this pull request?

What problem is this solving?

  • Open impersonating proxy vulnerabilities exposed by the executeCall method
  • Improve VtexIdclientAutCookie token validation
  • Improve marketplace seller connection validation performance

How to test it?

https://sellersendofferselefant--conttest108nov405.myvtex.com/admin/mkp-category-mapper/a8bcbda1-c97e-45ed-b506-1cdff1828b05/

curl --location --request GET 'https://sellersendofferselefanttest--elefantqa.myvtex.com/mkp-seller-auth/v0/healthcheck'
curl --location --request GET 'https://##WORKSPACE##--##ACCOUNT##.myvtex.com/mkp-seller-auth/v0/api/catalog/pvt/category/1' \
--header 'VtexIdclientAutCookie: ##REDACTED##'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Internal reference

@alexminza alexminza self-assigned this Jan 9, 2023
@alexminza alexminza changed the base branch from main to develop January 12, 2023 10:04
@alexminza alexminza marked this pull request as ready for review January 25, 2023 12:32
Copy link

@nicoletatattirdea nicoletatattirdea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants