Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API.md #162

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Update API.md #162

merged 3 commits into from
Jun 26, 2023

Conversation

Eric286
Copy link
Contributor

@Eric286 Eric286 commented Jun 22, 2023

added mport to the void sendUpLink

@Eric286
Update API.md
36f2a95 
Signed-off-by: Eric Chavez <[email protected]>
@sabas1080 sabas1080 self-requested a review June 22, 2023 20:47
sabas1080
sabas1080 requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@sabas1080 sabas1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta modificar el ejemplo de esa función, en el ejemplo siguen siendo 3 parametros y no 4

@Eric286
Update API.md
775d907 
Signed-off-by: Eric Chavez <[email protected]>
sabas1080
sabas1080 requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@sabas1080 sabas1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En el previo de la funcion se explica que valores puede tomar confirm, pero no se explica que valores puede tomar mport

@Eric286
Update API.md
687b65a 
Signed-off-by: Eric Chavez <[email protected]>
@sabas1080 sabas1080 merged commit 471930c into master Jun 26, 2023
@sabas1080 sabas1080 deleted the Eric286-patch-1 branch February 14, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabas1080 sabas1080 sabas1080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric286 @sabas1080