New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZIP 32 Arbitrary Key derivation #158

Open

str4d wants to merge 4 commits into release/0.11.0 from zip32-arbitrary-keys

Contributor

str4d commented Oct 23, 2024

No description provided.

str4d added 3 commits

October 23, 2024 16:48


          Fix some incorrect documentation

85ff329


          Move derivation-related FFI methods to a module

603c3d1

These are all methods exposed via `ZcashKeyDerivationBackend` in the
Swift SDK, that do not use a `WalletDb`.


          Add ZIP 32 Arbitrary Key derivation

28c4ac5

str4d mentioned this pull request

Add ZIP 32 Arbitrary Key derivation Electric-Coin-Company/zcash-swift-wallet-sdk#1501

Draft

14 tasks

nuttycom approved these changes

View reviewed changes

Contributor

nuttycom left a comment

utACK 28c4ac5 with comment/retroactive question about the zip32::arbitrary::SecretKey::from_path.

rust/src/derivation.rs Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs Outdated Show resolved Hide resolved

daira reviewed

View reviewed changes

rust/src/derivation.rs

+                  unwrap_exc_or_null(res)
+              }
+              /// Derives and returns a ZIP 32 Arbitrary Key from the given seed at the account level.

Contributor

daira Oct 30, 2024 •

edited

Loading

Should this document what the path is? (Non-blocking.)

daira reviewed

View reviewed changes

rust/src/derivation.rs Show resolved Hide resolved

daira approved these changes

View reviewed changes

Contributor

daira left a comment •

edited

Loading

utACK with comments. The comments about either documenting panics or making them into errors (I prefer the latter) are blocking.

If the decision is to keep the panics, that would also have to be documented at the SDK layer.


          Update safety documentation

54911ef

Co-authored-by: Daira-Emma Hopwood <[email protected]>

daira approved these changes

View reviewed changes

Contributor

daira left a comment

utACK

nuttycom mentioned this pull request

Enable retrieval of ephemeral addresses in zcashlc_list_transparent_receivers. #160

Open

str4d changed the base branch from main to release/0.11.0

November 6, 2024 21:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet