[#22] Configure Detekt

[ccjernigan]

Followup work includes:

• MnemonicCode Doesn't Implement Iterator Interface Correctly #46

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

• Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
• Automated tests: Did you add appropriate automated tests for any code changes?
• Documentation: Did you update documentation as appropriate? (e.g README.md, etc.)
• Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

• Checklist review: Did you go through the code with the Code Review Guidelines checklist?
• Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
• Automated tests: Did you review the automated tests?
• Manual tests: Did you review the manual tests?
• How is Code Coverage affected by this PR? We encourage you to compare coverage before and after changes and when possible, leave it in a better place.
• Documentation: Did you review Docs and README.md as appropriate?

[HonzaR]

Thanks. Seems good to me. Just one little thing, do we want to be able to run the Detekt checks also from Android studio? Then we need to have e.g. detektAll.run.xml in /.run/ folder.

[ccjernigan]

Thanks. Seems good to me. Just one little thing, do we want to be able to run the Detekt checks also from Android studio? Then we need to have e.g. detektAll.run.xml in /.run/ folder.

Yes, good catch. I'll fix that now. Thank you!