Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Common and JVM-only code #158

Merged
merged 9 commits into from
Feb 10, 2023
Merged

Separate Common and JVM-only code #158

merged 9 commits into from
Feb 10, 2023

Commits on Feb 8, 2023

  1. Separate common code from java. Remove use of jvm only code in common

    @luca992
    luca992 committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    50845ca View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. remove explicit constructors from SecureRandom

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    8b8da5c View commit details
    Browse the repository at this point in the history

  2. make secureRandom private

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9086fc5 View commit details
    Browse the repository at this point in the history

  3. class SecureRandom -> class SecureRandom() 

    resolves fake ide error: `Expected class SecureRandom does not have default constructor`
It builds either way
    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e561f50 View commit details
    Browse the repository at this point in the history

  4. run ktlintFormat

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2b3a1de View commit details
    Browse the repository at this point in the history

  5. run detektAll 

    make Pbkdf2Sha512.F private
    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    b8098b6 View commit details
    Browse the repository at this point in the history

  6. make jvmSecretKeyFactory private

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    af7be37 View commit details
    Browse the repository at this point in the history

  7. make classes in crypto package internal

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a82d5d9 View commit details
    Browse the repository at this point in the history

  8. make common package internal

    @luca992
    luca992 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    04b2ee5 View commit details
    Browse the repository at this point in the history