MnemonicCode Doesn't Implement Iterator Interface Correctly #46
Labels
bug
Something isn't working
Comments
ccjernigan
added a commit
that referenced
this issue
May 4, 2022
- Followup issue #46 Added a baseline file to suppress warnings for existing issues, while enabling Detekt to run on CI so that new issues won't be introduced going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running detekt points out:
kotlin-bip39/lib/src/jvmMain/kotlin/cash/z/ecc/android/bip39/Mnemonics.kt:85:53: This implementation of Iterator does not correctly implement the next() method as it doesn't throw a NoSuchElementException when no elements remain in the Iterator. [IteratorNotThrowingNoSuchElementException]
Note that the detekt baseline will suppress this warning. When implementing this change, be sure to update the detekt baseline file to remove this suppression.
The text was updated successfully, but these errors were encountered: