-
Notifications
You must be signed in to change notification settings - Fork 254
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4473 from EdgeApp/jon/ab/create-login-buttons
- added: Experiment config support between gui and login-ui - added: Experiment config for "Create Account" button labels
- Loading branch information
Showing
18 changed files
with
170 additions
and
86 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| import { asObject, asOptional, asValue, Cleaner } from 'cleaners' | ||
| import { makeReactNativeDisklet } from 'disklet' | ||
| import { CreateAccountType } from 'edge-login-ui-rn' | ||
| import { isMaestro } from 'react-native-is-maestro' | ||
|
|
||
| import { LOCAL_EXPERIMENT_CONFIG } from './constants/constantSettings' | ||
|
|
||
| // Persistent experiment config for A/B testing. Values initialized in this | ||
| // config persist throughout the liftetime of the app install. | ||
| export interface ExperimentConfig { | ||
| swipeLastUsp: 'true' | 'false' | ||
| createAccountType: CreateAccountType | ||
| legacyLanding: 'legacyLanding' | 'uspLanding' | ||
| createAccountText: 'signUp' | 'getStarted' | 'createAccount' | ||
| } | ||
|
|
||
| const experimentConfigDisklet = makeReactNativeDisklet() | ||
|
|
||
| // The probability (0-1) of a feature config being set to the first value(s): | ||
| // the configuration that differs from the default feature configuration. | ||
| const experimentDistribution = { | ||
| swipeLastUsp: [0.5], | ||
| createAccountType: [0.1], | ||
| legacyLanding: [0.5], | ||
| createAccountText: [0.33, 0.33] | ||
| } | ||
|
|
||
| /** | ||
| * Generate a random index value according to the experiment distribution to | ||
| * determine which variant gets used. | ||
| */ | ||
| const generateExperimentConfigVal = <T>(key: keyof typeof experimentDistribution, configVals: T[]): T => { | ||
| const variantProbability = experimentDistribution[key] | ||
|
|
||
| if (variantProbability.length !== configVals.length - 1) { | ||
| console.error(`Misconfigured experimentDistribution for: '${key}'`) | ||
| } else { | ||
| // Generate a random number between 0 and 1 | ||
| const random = Math.random() | ||
|
|
||
| // Check which index the random number falls into and return the configVal: | ||
| let lowerBound = 0 | ||
| for (let i = 0; i < variantProbability.length; i++) { | ||
| if (random >= lowerBound && random < variantProbability[i]) return configVals[i] | ||
| lowerBound += variantProbability[i] | ||
| } | ||
| } | ||
|
|
||
| return configVals[configVals.length - 1] | ||
| } | ||
|
|
||
| // It's important to define string literals instead of booleans as values so | ||
| // that they are properly captured in the analytics dashboard reports. The first | ||
| // values are the variant values that differ from the default feature | ||
| // behavior/appearance, while the last value represents unchanged | ||
| // behavior/appearance. | ||
| // If no generateCfgValFn given, returns defined defaults | ||
| // Error: Return type annotation circularly references itself. | ||
| const asExperimentConfig: (isDefault?: boolean) => Cleaner<ExperimentConfig> = isDefault => | ||
| asObject({ | ||
| swipeLastUsp: asOptional<'true' | 'false'>(asValue('true', 'false'), isDefault ? 'false' : generateExperimentConfigVal('swipeLastUsp', ['true', 'false'])), | ||
| createAccountType: asOptional<CreateAccountType>( | ||
| asValue('light', 'full'), | ||
| isDefault ? 'full' : generateExperimentConfigVal('createAccountType', ['light', 'full']) | ||
| ), | ||
| legacyLanding: asOptional<'legacyLanding' | 'uspLanding'>( | ||
| asValue('legacyLanding', 'uspLanding'), | ||
| isDefault ? 'uspLanding' : generateExperimentConfigVal('legacyLanding', ['legacyLanding', 'uspLanding']) | ||
| ), | ||
| createAccountText: asOptional<'signUp' | 'getStarted' | 'createAccount'>( | ||
| asValue('signUp', 'getStarted', 'createAccount'), | ||
| isDefault ? 'createAccount' : generateExperimentConfigVal('createAccountText', ['signUp', 'getStarted', 'createAccount']) | ||
| ) | ||
| }) | ||
|
|
||
| /** | ||
| * Immediately initialize the experiment config as soon as the module loads. | ||
| * This config value is available through the module's getter functions. | ||
| */ | ||
| const experimentConfigPromise: Promise<ExperimentConfig> = (async (): Promise<ExperimentConfig> => { | ||
| try { | ||
| const experimentConfigJson = await experimentConfigDisklet.getText(LOCAL_EXPERIMENT_CONFIG) | ||
| return asExperimentConfig(false)(JSON.parse(experimentConfigJson)) | ||
| } catch (err) { | ||
| // Not found or incompatible. Re-generate with random values according to | ||
| // the defined distribution. | ||
| const generatedExperimentConfig = asExperimentConfig(false)({}) | ||
| await experimentConfigDisklet.setText(LOCAL_EXPERIMENT_CONFIG, JSON.stringify(generatedExperimentConfig)) | ||
| return generatedExperimentConfig | ||
| } | ||
| })() | ||
|
|
||
| /** | ||
| * Initializes the local experiment config file containing the randomly | ||
| * generated variant values. This is used for variant values that are required | ||
| * prior to the initialization of the fetched config. Once generated, values | ||
| * 'stick' until the config type changes. | ||
| */ | ||
| export const getExperimentConfig = async (): Promise<ExperimentConfig> => { | ||
| if (isMaestro()) return asExperimentConfig(true)({}) // Test with forced defaults | ||
| return await experimentConfigPromise | ||
| } | ||
|
|
||
| /** | ||
| * Returns the experiment config value | ||
| */ | ||
| export const getExperimentConfigValue = async <K extends keyof ExperimentConfig>(key: K): Promise<ExperimentConfig[K]> => { | ||
| const config = await getExperimentConfig() | ||
| return config[key] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.