Skip to content

Commit

Permalink
Merge pull request #5194 from EdgeApp/sam/pull-to-refresh
Browse files Browse the repository at this point in the history
Remove pull down to refresh
  • Loading branch information
samholmes authored Aug 13, 2024
2 parents d6c3e62 + 7f395db commit 71e0164
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 24 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- fixed: Do not spin forever if the spam filter eliminates too many transactions.
- fixed: FIO OBT data not showing in received transaction memos
- fixed: Return underLimit error for Simplex for very small quotes
- removed: Removed pull-to-search feature from wallet list and transaction list scenes

## 4.11.0

Expand Down
14 changes: 1 addition & 13 deletions src/components/scenes/TransactionListScene.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { EdgeCurrencyWallet, EdgeTokenId, EdgeTokenMap, EdgeTransaction } from 'edge-core-js'
import { AssetStatus } from 'edge-info-server'
import * as React from 'react'
import { ListRenderItemInfo, RefreshControl, View } from 'react-native'
import { ListRenderItemInfo, View } from 'react-native'
import { getVersion } from 'react-native-device-info'
import Animated from 'react-native-reanimated'

Expand Down Expand Up @@ -187,17 +187,6 @@ function TransactionListComponent(props: Props) {
// Renderers
//

const refreshControl = React.useMemo(() => {
return (
<RefreshControl
refreshing={false}
tintColor={theme.searchListRefreshControlIndicator}
// useHandler isn't needed, since we're already in useMemo:
onRefresh={() => setIsSearching(true)}
/>
)
}, [theme])

const topArea = React.useMemo(() => {
return (
<>
Expand Down Expand Up @@ -320,7 +309,6 @@ function TransactionListComponent(props: Props) {
ListEmptyComponent={emptyComponent}
ListHeaderComponent={topArea}
onEndReachedThreshold={0.5}
refreshControl={refreshControl}
renderItem={renderItem}
// TODO: Comment out sticky header indices until we figure out how to
// give the headers a background only when they're sticking.
Expand Down
11 changes: 0 additions & 11 deletions src/components/scenes/WalletListScene.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ export function WalletListScene(props: Props) {
.catch(error => showError(error))
})

const handleRefresh = useHandler(() => {
setIsSearching(true)
})

const handleReset = useHandler(() => {
setSearchText('')
setIsSearching(false)
})

const handleStartSearching = useHandler(() => {
setIsSearching(true)
})
Expand Down Expand Up @@ -148,8 +139,6 @@ export function WalletListScene(props: Props) {
insetStyle={insetStyle}
searching={isSearching}
searchText={searchText}
onRefresh={handleRefresh}
onReset={handleReset}
/>
<WalletListSortable insetStyle={insetStyle} key="sortList" />
</CrossFade>
Expand Down

0 comments on commit 71e0164

Please sign in to comment.