Adds browser notifications #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only fire when all tabs are not visible/open - Click event will focus an open tab or create one if there are none - Now show user's name in title - Original filename is shown in content when files are sent
Closed
|
Looks good. Don't forget to update |
Additionally, reworks the promise logic a bit in dashboard.js. New error catch for vapid key changes that automatically unsubscribes and resubscribes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will effectively add notifications delivered by the browser to the user. The notifications only fire when there is no spiteful tab currently visible. They can be clicked to either focus an open spiteful tab or open a new one. A toggle for notifications is also now included in the settings modal.