Bugfix/maxou/fix timeout serial #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2023 18:17
|
Can you please accept it so I can put this behind me :( |
udit7395
reviewed
Sep 11, 2023
| @@ -245,14 +245,21 @@ int waitForSerialData(int dataCount, int timeout) | |||
| { | |||
| int timer = 0; | |||
| int length = 0; | |||
| while (timer < timeout) | |||
|
|
|||
| int ticks = pdMS_TO_TICKS(timeout); | |||
There was a problem hiding this comment.
@laukik-hase is this method available in the IDF version we used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix, the delay doesn't work
There were a bug where the timeout is not respected, causing it to not work in some situation.
This line:
vTaskDelay(1 / portTICK_PERIOD_MS);
If FreeRTOS is set lower than 1000 HZ (1 ms per tick) it cause the calculation to return 0 so it doesn't have any meaningful delay.
Now it does with this fix.
If FreeRTOS is set a 100 HZ (10 ms per tick) with 1000 ms timeout, the loop will operate 100 times and create 100x10ms delay.
See: #4
Prescribed delay is not sufficient
I needed more than 8s to erase flash memory on my microcontroller so 5s is insufficient. Especially if the micro is not a new one.
Header too big to parse
Some modern browser have a tendency to produce ridiculously big HTTP GET header, I increased the webserver buffer size to repair this.