Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamp to rpointer files #2757

Open
wants to merge 1 commit into
base: b4b-dev
Choose a base branch
from

Conversation

jedwards4b
Copy link
Contributor

Description of changes

Adds a timestamp to rpointer files in a backward compatible manor

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?
no
Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
ERR_Ln9_C3.ne30pg3_ne30pg3_mg17.FLTHIST.derecho_intel.cam-outfrq9s
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@wwieder
Copy link
Contributor

wwieder commented Sep 12, 2024

Thanks Jim. Can this go onto b4bdev, @ekluzek ?

@ekluzek ekluzek self-assigned this Sep 12, 2024
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options labels Sep 12, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 12, 2024

Thanks @jedwards4b.

@wwieder yes this totally makes sense as something coming into b4b-dev. Since, it has backwards compatibility it doesn't need to be coordinated with other CESM tags or externals. So bringing it into b4b-dev and having it go into CTSM main-dev the next time a b4b-dev tag is made (in two weeks) makes a lot of sense.

@jedwards4b jedwards4b marked this pull request as draft September 19, 2024 20:05
@jedwards4b
Copy link
Contributor Author

I've run into an issue here. The clm_timemgr reads its clock information from the restart file on restart - which makes it hard to read the clock to read the restart file. It's also not a requirement to get this from the restart file as the driver has already set the clock.

@wwieder wwieder added this to the cesm3_0_beta04 milestone Sep 26, 2024
@jedwards4b jedwards4b marked this pull request as ready for review September 26, 2024 20:59
@jedwards4b
Copy link
Contributor Author

I have tested with ERS.ne30pg3_t232.BLT1850.derecho_intel.allactive-defaultio
and plan to do a complete set of cesm prealpha tests.

@samsrabin
Copy link
Collaborator

We discussed this at the CTSM SE meeting this morning and decided it would be in our cesm3_0_beta04 tag, which fits with @jedwards4b's timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants