create new test case for ccd

[zywshoon]

No description provided.

[zywshoon]

I have no idea what to do with these 1000 changes... I only changed Makefile and add a new test case in tests/.

[fvitt]

@zywshoon
It seems that you added source/.DS_Store, build, doc/f90doc, and run in your commit to your branch. You should not add these. Try removing them from your branch via git rm source/.DS_Store, git rm build, etc. Then commit and push to your github fork.

[zywshoon]

Ok. It is reasonable now. Let me know what's next. I don't think all the changes should be adopted since some setup in Makefile is only for running on my own computer.

[fvitt]

@zywshoon

I will clone your branch on casper when it is back up. There I will create the new baselines.

Something happened to the doc/ChangeLog, doc/ChangeLog_template, and doc/index.html files in your branch. I will restore those.

I will also remove the changes to the Makefile you did for your computer.

Then I will try to push to your github fork / branch.

[fvitt]

@zywshoon
I am seeing differences in these bench data files:

        modified:   tests/bench/carma_fractalmicrotest.txt
        modified:   tests/bench/carma_sulfate_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfatetest.txt
        modified:   tests/bench/carma_sulfhet_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfhettest.txt

And there is 1 new file:

        new file:   tests/bench/carma_sigmavdry.txt

Is this what you expect?

[zywshoon]

@zywshoon I am seeing differences in these bench data files:

        modified:   tests/bench/carma_fractalmicrotest.txt
        modified:   tests/bench/carma_sulfate_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfatetest.txt
        modified:   tests/bench/carma_sulfhet_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfhettest.txt

And there is 1 new file:

        new file:   tests/bench/carma_sigmavdry.txt

Is this what you expect?

The modified bench .txt files look correct to me.

carma_sigmavdry.txt is not the new file. the new file should be carma_sulfate_ccdon.F90 and carma_sulfate_ccdon.txt

Did I miss uploading them?

[fvitt]

@zywshoon
My mistake. It turns out that the name of the new test executable needs to end with TEST.EXE for run-regress.csh to work correctly. So I renamed your new test to include _test.
Now I have :

        new file:   tests/bench/carma_sulfate_ccdon_test.txt
        renamed:    tests/carma_sulfate_ccdon.F90 -> tests/carma_sulfate_ccdon_test.F90

        modified:   tests/bench/carma_fractalmicrotest.txt
        modified:   tests/bench/carma_sulfate_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfatetest.txt
        modified:   tests/bench/carma_sulfhet_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfhettest.txt
        modified:   tests/carma_sulfate_ccdon_test.F90

Do these change make sense now?

[zywshoon]

@zywshoon My mistake. It turns out that the name of the new test executable needs to end with TEST.EXE for run-regress.csh to work correctly. So I renamed your new test to include _test. Now I have :

        new file:   tests/bench/carma_sulfate_ccdon_test.txt
        renamed:    tests/carma_sulfate_ccdon.F90 -> tests/carma_sulfate_ccdon_test.F90

        modified:   tests/bench/carma_fractalmicrotest.txt
        modified:   tests/bench/carma_sulfate_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfatetest.txt
        modified:   tests/bench/carma_sulfhet_vehkamaki_test.txt
        modified:   tests/bench/carma_sulfhettest.txt
        modified:   tests/carma_sulfate_ccdon_test.F90

Do these change make sense now?

Yes. These look correct to me.