Add capability for SCAM forcing based on gridded met fields. #595

JulioTBacmeister · 2022-05-20T17:34:46Z

This capability currently requires pre-computed gridded fields on FV latlon 1 degree grid

Have run a number of cases using this capability - can provide user_nl_cam as well path to gridded ERA reanalysis.

Have also run with this capability is off and standard SCAM IOPs. Answers look fine but have not done rigorous testing.

closes #594

Merge remote-tracking branch 'ESCOMP/cam_development' into cam_development

…/CAM into cam_development

jtruesdal · 2022-05-25T19:25:23Z

@JulioTBacmeister could you add @jtruesdal as a developer on your repo if it's OK for me to make changes to this branch for the PR.

JulioTBacmeister · 2022-05-25T20:20:31Z

@jtruesdal I've made you a collaborator and github implies you should have received an invite of some sort. Let me know if I should do something else.

peverwhee · 2022-05-26T22:11:25Z

@JulioTBacmeister @jtruesdal

Jim Edwards came across the following when debugging our CICE/SCAM issues:

Because the namelist variable scm_ana_frc_file_template is a template rather than an actual file, this message appears when you build:

Model cam missing file scm_ana_frc_file_template = '%y/ERAI_fv09_L58.cam2.i.%y-%m-%d-%s.nc'

To avoid this, we may need a change to CAM's buildnml so that this isn't written to the
Buildconf/cam.input_data_list

JulioTBacmeister · 2022-05-27T15:49:35Z

Yes. I've noticed this message. The model nevertheless builds and runs without issues. This should have also come up when the nudging code was incorporated - it uses a similar template.

peverwhee · 2022-05-27T16:15:30Z

Yes. I've noticed this message. The model nevertheless builds and runs without issues. This should have also come up when the nudging code was incorporated - it uses a similar template.

Gotcha. I'll open a low-priority issue for the nudging message.

peverwhee · 2022-05-27T21:38:03Z

@JulioTBacmeister @jtruesdal

OK, bringing this up again because it looks like the logic can handle the nudging template file because it does not see it as an absolute path (and thus we do not get the warning). Because of the "%y/" at the start of the scm_ana_frc_file_template file, we get the warning for this new variable.

If you replace line 4405 in bld/build_namelist with the following (to not write the variables whose pathnames start with '%' to the cam.input_data_list file), it should remove the warning:

if (!($pathname =~ '%.*') {
    print $fh "$var = $pathname\n";
}

I'm also happy to make a PR to your branch with this change.

Thanks!

Merge branch 'cam_development' of https://github.com/JulioTBacmeister/CAM into cam_development

JulioTBacmeister · 2022-05-27T22:19:25Z

@peverwhee @jtruesdal - I made the change in build_namelist on my branch and pushed it to origin. Would you check it?

peverwhee · 2022-05-27T23:23:38Z

@JulioTBacmeister Looks good to me. Sorry my code snippet was missing a parenthesis! Thanks!

gold2718

Suggested approach to problem with pathnames.

gold2718 · 2022-05-28T06:53:41Z

bld/namelist_files/namelist_definition.xml

+<entry id="scm_ana_frc_file_template" type="char*128" input_pathname="abs" category="scam"
+       group="scam_nl" valid_values="" >
+template for analysis forcing dataset.
+Default: set by build-namelist.
+</entry>


This variable is a string, not a filename (path), therefore, it should not have the input_pathname attribute. I believe this is the source of the build-namelist problems.

gold2718 · 2022-05-28T06:54:31Z

bld/build-namelist

+                        if (!($pathname =~ '%.*')) {
+                            print $fh "$var = $pathname\n";


I do not think this should be needed (see below) and could have unintended effects.

Should these lines be removed altogether? Or replaced with what was there before?

It should be replaced with what was there before. I opened a PR with the changes if that helps (you can also close it if you don't need it):

JulioTBacmeister#1

Apologies for any whiplash you may be experiencing.

Revert build-namelist change and remove input_pathname argument

Merge remote-tracking branch 'refs/remotes/origin/cam_development' into cam_development

…o.csh

JulioTBacmeister · 2022-06-07T21:45:17Z

Removed
cime_config/usermods_dirs/scam_STUB/scripts/make_basecase.auto.csh
cime_config/usermods_dirs/scam_STUB/scripts/run_cases.csh

Not sure what to do with
cime_config/usermods_dirs/scam_STUB/scripts/STUB_iop.nc

Want to note problems with
cime_config/usermods_dirs/scam_STUB/user_nl_cam

Functionality of make_basecase.auto.csh should incorporated somewhere, i,e. new compset, new script like 'create_newcase'

Need for STUB_iop.nc should also be looked at.

peverwhee · 2022-06-08T19:11:39Z

@nusbaume @cacraigucar and I recommended (via email) that Julio remove the shell scripts and ncdata file from the scam_STUB usermods directory. Documenting that here.

XML variables set in the shell script(s) can be set in scam_STUB/shell_commands and variables written to user_nl_cam can be added to scam_STUB/user_nl_cam

cacraigucar · 2022-06-08T20:48:26Z

@JulioTBacmeister and @adamrher - Is this Stub IOP another IOP which we want to support? If so, I would suggest that the user_nl_cam and shell_commands be put in cime_config/usermods_dirs/scam_Stub_IOP or something like that. You can see what was done for cime_config/usermods_dirs/scam_arm97 as an example. @jtruesdal may be able to give some addtional guidance as he's done this more recently than I have.

jtruesdal · 2022-06-21T14:59:54Z

@cacraigucar I agree that this needs to be looked at and will meet with Julio to discuss options.

…/CAM into cam_development This is bringing stuff from Cheyenne: 1) Allow runs on Cheyenne; 2) Enable L93

cacraigucar · 2022-07-27T16:32:19Z

Externals_CAM.cfg

+protocol = svn
+repo_url = https://github.com/larson-group/clubb_release/tags/
+tag = clubb_4ncar_20220311_f51de38/src/CLUBB_core
 required = True

 [silhs]
 local_path = src/physics/silhs
-protocol = git
-repo_url = https://github.com/ESCOMP/SILHS_CESM
-tag = silhs_clubb_release_b76a124_20200220_c20200320
+protocol = svn
+repo_url = https://github.com/larson-group/clubb_release/tags/
+tag = clubb_4ncar_20220311_f51de38/src/SILHS


@JulioTBacmeister - Are these changes really needed for your SCAM PR? Hopefully you can use the tags that are currently being used in CAM instead

I want to use the "new" CLUBB external brought in with cam6_3_059. This is so that we can assess prognostic momentum transport using SCAM.

JulioTBacmeister · 2022-07-28T21:10:28Z

Superseded by PR #628

Julio Bacmeister and others added 5 commits December 2, 2021 15:20

Want to start GW development from latest cam_development

e7c0a09

Merge remote-tracking branch 'ESCOMP/cam_development' into cam_development

Merge branch 'ESCOMP:cam_development' into cam_development

0f219fd

Merge branch 'ESCOMP:cam_development' into cam_development

14b65ee

Capability for SCAM to be driven by gridded met fields

7f43caa

Merge branch 'cam_development' of https://github.com/JulioTBacmeister…

496c209

…/CAM into cam_development

JulioTBacmeister added the enhancement New feature or request label May 21, 2022

JulioTBacmeister changed the title ~~Add capability for SCAM forcing based on gridded met fields. Connected to issue #594.~~ Add capability for SCAM forcing based on gridded met fields. May 21, 2022

correcting dimensions of PKO,RV in get_ana_dynfrc_4scam.F90

bb4cca9

cacraigucar assigned jtruesdal May 24, 2022

Julio Bacmeister added 2 commits May 26, 2022 09:38

moving mountain

d542611

trying to restore original intent

103a3c5

Julio Bacmeister added 2 commits May 27, 2022 16:17

buildnml mod to accomodate templtes with %

6be8815

must be necessary

91dc7e4

Merge branch 'cam_development' of https://github.com/JulioTBacmeister/CAM into cam_development

missing )

6b98a09

gold2718 requested changes May 28, 2022

View reviewed changes

Courtney Peverley and others added 7 commits May 31, 2022 10:11

revert change to build-namelest

31846dd

revert again

5c96d42

Merge pull request #1 from peverwhee/scam_julio

e51206f

Revert build-namelist change and remove input_pathname argument

redo build-namelist

e7133bf

Merge remote-tracking branch 'refs/remotes/origin/cam_development' into cam_development

updated make_basecase.auto.csh

77aa2cc

removed cime_config/usermods_dirs/scam_STUB/scripts/run_cases.csf

2d1ded5

removed cime_config/usermods_dirs/scam_STUB/scripts/make_basecase.aut…

807811f

…o.csh

cacraigucar requested a review from jtruesdal July 12, 2022 00:30

Julio Bacmeister and others added 12 commits July 14, 2022 11:38

Updated to new CLUBB external

89fac35

Python tools etc for SCAM

5ca9af9

forgot case_name

e5be7c3

name change

6560907

working on python, clubbtop

35d50be

Externals_CAM updated

0b9fad0

mflit etc

33f1d5c

adding some plotting

7fa25e0

adding support for cheyenne and L93

7660d98

typo/syntax and UBC for H2O

fd648c6

Merge branch 'cam_development' of https://github.com/JulioTBacmeister…

b8ec3dc

…/CAM into cam_development This is bringing stuff from Cheyenne: 1) Allow runs on Cheyenne; 2) Enable L93

added machine recognition, ie., izumi, cheyenne

8405550

cacraigucar reviewed Jul 27, 2022

View reviewed changes

Julio Bacmeister added 2 commits July 27, 2022 12:16

more support for diff machines etc.

3676dc7

clean up

e9cdc1b

JulioTBacmeister mentioned this pull request Jul 28, 2022

external gridded forcing capability for SCAM #628

Open

JulioTBacmeister closed this Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add capability for SCAM forcing based on gridded met fields. #595

Add capability for SCAM forcing based on gridded met fields. #595

JulioTBacmeister commented May 20, 2022 •

edited by peverwhee

Loading

jtruesdal commented May 25, 2022

JulioTBacmeister commented May 25, 2022

peverwhee commented May 26, 2022

JulioTBacmeister commented May 27, 2022

peverwhee commented May 27, 2022

peverwhee commented May 27, 2022

JulioTBacmeister commented May 27, 2022 •

edited

Loading

peverwhee commented May 27, 2022

gold2718 left a comment

gold2718 May 28, 2022

gold2718 May 28, 2022

JulioTBacmeister Jun 1, 2022

peverwhee Jun 1, 2022

JulioTBacmeister commented Jun 7, 2022

peverwhee commented Jun 8, 2022

cacraigucar commented Jun 8, 2022

jtruesdal commented Jun 21, 2022

cacraigucar Jul 27, 2022

JulioTBacmeister Jul 27, 2022

JulioTBacmeister commented Jul 28, 2022

Add capability for SCAM forcing based on gridded met fields. #595

Add capability for SCAM forcing based on gridded met fields. #595

Conversation

JulioTBacmeister commented May 20, 2022 • edited by peverwhee Loading

jtruesdal commented May 25, 2022

JulioTBacmeister commented May 25, 2022

peverwhee commented May 26, 2022

JulioTBacmeister commented May 27, 2022

peverwhee commented May 27, 2022

peverwhee commented May 27, 2022

JulioTBacmeister commented May 27, 2022 • edited Loading

peverwhee commented May 27, 2022

gold2718 left a comment

Choose a reason for hiding this comment

gold2718 May 28, 2022

Choose a reason for hiding this comment

gold2718 May 28, 2022

Choose a reason for hiding this comment

JulioTBacmeister Jun 1, 2022

Choose a reason for hiding this comment

peverwhee Jun 1, 2022

Choose a reason for hiding this comment

JulioTBacmeister commented Jun 7, 2022

peverwhee commented Jun 8, 2022

cacraigucar commented Jun 8, 2022

jtruesdal commented Jun 21, 2022

cacraigucar Jul 27, 2022

Choose a reason for hiding this comment

JulioTBacmeister Jul 27, 2022

Choose a reason for hiding this comment

JulioTBacmeister commented Jul 28, 2022

JulioTBacmeister commented May 20, 2022 •

edited by peverwhee

Loading

JulioTBacmeister commented May 27, 2022 •

edited

Loading