chore: fix variable name

EJTJ3 · Jul 27, 2023 · 7f99682 · 7f99682
1 parent ba1178b
commit 7f99682
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/src/Connection/ClientConnectionOptions.php b/src/Connection/ClientConnectionOptions.php
@@ -15,7 +15,7 @@ public function __construct(
         /**
          * Turns on +OK protocol acknowledgements.
          */
-        private bool $verbose = true,
+        private bool $verbose = false,
 
         /**
          * Turns on additional strict format checking, e.g. for properly formed subjects.

diff --git a/src/Connection/NatsConnection.php b/src/Connection/NatsConnection.php
@@ -46,14 +46,28 @@ public function __construct(
         $this->currentServer = null;
         $this->connected = false;
         $this->isVerbose = false;
+        $this->enableNoResponder = false;
     }
 
     public function setNoResponders(bool $enabled = true): void
     {
+        if ($this->isConnected()) {
+            throw new InvalidArgumentException('Stream is already connected, enable no-responders before connecting. ');
+        }
+
         // Headers must be enabled for no responders.
         $this->enableNoResponder = $enabled;
     }
 
+    public function setVerbose(bool $verbose): void
+    {
+        if ($this->isConnected()) {
+            throw new InvalidArgumentException('Stream is already connected, enable verbose before connecting. ');
+        }
+
+        $this->isVerbose = $verbose;
+    }
+
     /**
      * @throws Exception
      */
@@ -217,16 +231,14 @@ private function doConnect(): void
         $server = $this->currentServer;
 
         $connectionOptions = new ClientConnectionOptions();
-        $connectionOptions->setPedantic(false);
-        $connectionOptions->setVerbose(false);
 
         if ($this->enableNoResponder) {
             $connectionOptions->setNoResponders(true);
             $connectionOptions->setHeaders(true);
         }
 
-        if ($connectionOptions->isVerbose() === true) {
-            $this->isVerbose = true;
+        if ($this->isVerbose === true) {
+            $connectionOptions->setVerbose(true);
         }
 
         if (!StringUtil::isEmpty($server->getUser()) && !StringUtil::isEmpty($server->getPassword())) {

diff --git a/src/Connection/Response.php b/src/Connection/Response.php
@@ -16,6 +16,10 @@ public static function parse(string $payload): NatsResponseInterface
             return new Pong();
         }
 
+        if (NatsProtocolOperation::Ping->isOperation($payload)) {
+            return new Ping();
+        }
+
         if (NatsProtocolOperation::Ack->isOperation($payload)) {
             return new Acknowledgement();
         }
@@ -38,14 +42,10 @@ public static function parse(string $payload): NatsResponseInterface
             throw new RuntimeException('Operation is not supported');
         }
 
-        dump($operation);
-
         return match ($operation) {
             NatsProtocolOperation::HEADER_MSG => HMsg::create($body),
             NatsProtocolOperation::Msg => Msg::create($body),
             NatsProtocolOperation::Info => \EJTJ3\PhpNats\Connection\ServerInfo::fromData($body),
-            NatsProtocolOperation::Ping => new Ping(),
-            NatsProtocolOperation::Pong => new Pong(),
             default => throw new LogicException('Not implemented yet')
         };
     }