feat: upgrade phpstan to v2

composer.json

@@ -18,7 +18,8 @@
         "ext-json": "*"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0"
+        "phpunit/phpunit": "^9.0",
+        "phpstan/phpstan": "^2.0"
     },
     "scripts": {
         "test": "vendor/bin/phpunit"

phpstan.neon

@@ -1,6 +1,4 @@
 parameters:
-    level: 7 # 0 - loose, 8 - strict
+    level: 9
     paths:
         - src
-    checkGenericClassInNonGenericObjectType: false
-    checkMissingIterableValueType: false

src/Connection/ClientConnectionOptions.php

@@ -143,7 +143,7 @@ public function setName(?string $name): void
         $this->name = $name;
     }
 
-    public function getProtocol(): ?int
+    public function getProtocol(): int
     {
         return $this->protocol;
     }

src/Connection/Msg.php

@@ -10,9 +10,9 @@
 final class Msg implements MessageInterface
 {
     /**
-     * @var string|null the message payload data
+     * @var string the message payload data
      */
-    private ?string $payload;
+    private string $payload;
 
     private function __construct(
         // subject name this message was received on - always

src/Connection/NatsConnectionOption.php

@@ -48,7 +48,7 @@ public function __construct(
                         return $server;
                     }
 
-                    if (is_string($server) && StringUtil::isEmpty($server) === false) {
+                    if (StringUtil::isEmpty($server) === false) {
                         return new Server($server);
                     }
 

src/Connection/ServerCollection.php

@@ -29,10 +29,6 @@ public function __construct(array $servers, bool $randomize = false)
         }
 
         foreach ($servers as $server) {
-            if (!$server instanceof Server) {
-                throw new InvalidArgumentException(sprintf('Servers must be of type %s.', Server::class));
-            }
-
             $this->addServer($server);
         }
     }

src/Connection/ServerInfo.php

@@ -154,12 +154,12 @@ public function getVersion(): string
         return $this->version;
     }
 
-    public function isTlsRequired(): ?bool
+    public function isTlsRequired(): bool
     {
         return $this->tlsRequired;
     }
 
-    public function isTlsVerified(): ?bool
+    public function isTlsVerified(): bool
     {
         return $this->tlsVerify;
     }

src/Logger/NullLogger.php

@@ -6,10 +6,11 @@
 
 use Psr\Log\AbstractLogger;
 use Psr\Log\LoggerInterface;
+use Stringable;
 
 final class NullLogger extends AbstractLogger implements LoggerInterface
 {
-    public function log($level, string|\Stringable $message, array $context = []): void
+    public function log($level, string|Stringable $message, array $context = []): void
     {
     }
 }