Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat precommit nbstripout #197

Merged
merged 23 commits into from
Jun 30, 2023

Conversation

jmccreight
Copy link
Member

This is to follow #188

  • Closes #xxxx
  • Tests and/or performance benchmarks added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst or it's sub rsts?

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #197 (c7e1913) into develop (256dfbf) will increase coverage by 0.01%.
The diff coverage is 84.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #197      +/-   ##
===========================================
+ Coverage    79.52%   79.53%   +0.01%     
===========================================
  Files           51       51              
  Lines         6421     6430       +9     
===========================================
+ Hits          5106     5114       +8     
- Misses        1315     1316       +1     
Impacted Files Coverage Δ
pywatershed/analysis/process_plot.py 17.07% <0.00%> (ø)
pywatershed/base/control.py 92.80% <ø> (ø)
pywatershed/base/model.py 94.73% <ø> (ø)
pywatershed/base/parameters.py 90.00% <ø> (ø)
pywatershed/hydrology/prms_groundwater.py 97.80% <66.66%> (+0.02%) ⬆️
pywatershed/hydrology/prms_snow.py 90.47% <66.66%> (+0.01%) ⬆️
pywatershed/hydrology/prms_soilzone.py 88.23% <66.66%> (+0.03%) ⬆️
pywatershed/base/adapter.py 97.01% <100.00%> (ø)
pywatershed/base/data_model.py 81.76% <100.00%> (-0.06%) ⬇️
pywatershed/hydrology/prms_canopy.py 83.33% <100.00%> (+0.08%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight jmccreight closed this Jun 30, 2023
@jmccreight jmccreight reopened this Jun 30, 2023
@jmccreight jmccreight merged commit 2fb32b4 into EC-USGS:develop Jun 30, 2023
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants