Address review comments

EBIvariation · Oct 1, 2024 · 2f88982 · 2f88982
1 parent 6087ebd
commit 2f88982
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -125,7 +125,6 @@ jobs:
     - name: Compile and test
       run: |
         mkdir build && cd build && cmake -G "Unix Makefiles" -DCMAKE_CXX_COMPILER=${{ matrix.config.cxx }} -DCMAKE_C_COMPILER=${{ matrix.config.cc }} ..
-        export LIBRARY_PATH=${LIBRARY_PATH}:/opt/homebrew/opt/icu4c/lib:/opt/homebrew/lib
         make -j2
         cd .. && ./build/bin/test_validation_suite
     - name: Rename release files

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -87,7 +87,7 @@ if (LINUX)
 elseif (OSX)
   # Mac build not fully static. include system libraries to be dynamic
   set (CMAKE_EXE_LINKER_FLAGS)
-  set (Boost_USE_STATIC_LIBS OFF)            # only find static libs
+  set (Boost_USE_STATIC_LIBS OFF)            # use dynamically linked libraries
 elseif (WINDOWS)
   set (Boost_USE_STATIC_LIBS ON)             # only find static libs
   set (CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT") # also requires boost with runtime-link=static