EVA-3378 read scientific name from evapro #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,7 +98,9 @@ def semantic_validation(self): | |||
| taxid_and_species_list = set([(row['Tax Id'], row['Scientific Name']) for row in self.metadata['Sample'] if row['Tax Id']]) | |||
| for taxid, species in taxid_and_species_list: | |||
| try: | |||
| scientific_name = get_scientific_name_from_ensembl(int(taxid)) | |||
| scientific_name = get_scientific_name_from_taxonomy(int(taxid), | |||
There was a problem hiding this comment.
Given the possible latency across the different stages (metadata validation, brokering etc.,) I think we should nail down the scientific name just once at the outset (we can decide when this should be #devmeeting), add it to the EVA and use the metadata from EVA from there on.
tcezard
reviewed
Sep 22, 2023
|
Decided not to go ahead with this approach (will use the metadata api) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.