EVA-3554 Pass application instance id to generate accession #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
approved these changes
Apr 26, 2024
| @@ -46,7 +46,7 @@ public interface AccessioningService<MODEL, HASH, ACCESSION> { | |||
| * @return List of wrapper objects containing the accessioned objects and their associated accessions and hashes | |||
| * @throws AccessionCouldNotBeGeneratedException when accession could not be generated | |||
| */ | |||
| List<GetOrCreateAccessionWrapper<MODEL, HASH, ACCESSION>> getOrCreate(List<? extends MODEL> messages) | |||
| List<GetOrCreateAccessionWrapper<MODEL, HASH, ACCESSION>> getOrCreate(List<? extends MODEL> messages, String applicationInstanceId) | |||
There was a problem hiding this comment.
Can you update the method comment to explain what is the applicationInstanceId and why we're passing it ?
There was a problem hiding this comment.
Also I'm wondering if we should avoid reusing the variable applicationInstanceId in case there are still beans that would populate it from the properties file.
There was a problem hiding this comment.
Added the comment.
As These are parameter variables and not instance variables of a class, these would not get populated automatically.
| @@ -127,7 +124,7 @@ public synchronized long[] generateAccessions(int numAccessionsToGenerate) | |||
| * | |||
| * @param totalAccessionsToGenerate | |||
| */ | |||
| private synchronized void reserveNewBlocksUntilSizeIs(int totalAccessionsToGenerate) { | |||
| private synchronized void reserveNewBlocksUntilSizeIs(int totalAccessionsToGenerate, String applicationInstanceId) { | |||
There was a problem hiding this comment.
Same here can we update the comment ?
apriltuesday
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.