EVA-3260 update block allocation strategy #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
approved these changes
Mar 18, 2024
Comment on lines
79
to
90
| @Transactional(isolation = Isolation.SERIALIZABLE) | ||
| public List<ContiguousIdBlock> reserveUncompletedBlocksByCategoryIdAndApplicationInstanceIdOrderByEndAsc( | ||
| String categoryId, String applicationInstanceId) { | ||
| try (Stream<ContiguousIdBlock> reservedBlocksOfThisInstance = repository | ||
| .findAllByCategoryIdAndApplicationInstanceIdOrderByLastValueAsc(categoryId, applicationInstanceId)) { | ||
| return reservedBlocksOfThisInstance.filter(ContiguousIdBlock::isNotFull).collect(Collectors.toList()); | ||
| List<ContiguousIdBlock> blocksList = reservedBlocksOfThisInstance | ||
| .filter(block -> block.isNotFull() && block.isNotReserved()).collect(Collectors.toList()); | ||
|
|
||
| blocksList.stream().forEach(block -> block.markAsReserved()); | ||
| save(blocksList); | ||
|
|
||
| return blocksList; |
There was a problem hiding this comment.
If I'm not mistaken, this is the core of the process safe block reservation process. I feel like we should describe in a comment why/how this works.
There was a problem hiding this comment.
Maybe it makes more sense to describe this at the level of the class rather than this method.
There was a problem hiding this comment.
Added description on top of the class in the form of Javadoc to explain the behavior
There was a problem hiding this comment.
Great work, left some suggestions but otherwise happy to have this tested in a "real world" setting.
I agree with Tim that documentation for future developers (e.g. us in a couple years...) would be great. Even better would be updating the diagram and adding some explanation either there or in the code... this might be too large a task for this PR though.
...uk/ac/ebi/ampt2d/commons/accession/persistence/jpa/monotonic/entities/ContiguousIdBlock.java
Outdated
Show resolved
Hide resolved
...ebi/ampt2d/commons/accession/persistence/jpa/monotonic/service/ContiguousIdBlockService.java
Outdated
Show resolved
Hide resolved
...ebi/ampt2d/commons/accession/persistence/jpa/monotonic/service/ContiguousIdBlockService.java
Outdated
Show resolved
Hide resolved
...ampt2d/commons/accession/persistence/jpa/monotonic/service/ContiguousIdBlockServiceTest.java
Outdated
Show resolved
Hide resolved
...ampt2d/commons/accession/persistence/jpa/monotonic/service/ContiguousIdBlockServiceTest.java
Outdated
Show resolved
Hide resolved
.../ac/ebi/ampt2d/commons/accession/core/BasicMonotonicAccessioningWithAlternateRangesTest.java
Outdated
Show resolved
Hide resolved
...ebi/ampt2d/commons/accession/persistence/jpa/monotonic/service/ContiguousIdBlockService.java
Show resolved
Hide resolved
.../ac/ebi/ampt2d/commons/accession/core/BasicMonotonicAccessioningWithAlternateRangesTest.java
Outdated
Show resolved
Hide resolved
apriltuesday
approved these changes
Mar 20, 2024
...nerator-jpa/src/test/java/uk/ac/ebi/ampt2d/commons/accession/util/ContiguousIdBlockUtil.java
Outdated
Show resolved
Hide resolved
.../ac/ebi/ampt2d/commons/accession/core/BasicMonotonicAccessioningWithAlternateRangesTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.