EVA-1851 - Allow block allocation to recover from constraint violations #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundarvenkata-EBI
requested review from
andresfsilva,
jorizci and
jmmut
and removed request for
andresfsilva,
jorizci and
jmmut
|
@jmmut @jorizci @andresfsilva While the PR code works with the embedded database for the tests, I just ran into issues in the DEV database. I will move this ticket back to "In progress".... |
sundarvenkata-EBI
force-pushed
the
fix/recover_from_block_alloc_failures
branch
from
f5ef446
to
ac26c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some experimenting with concurrent runs of the accessioning pipeline across multiple machines, I discovered that the exponential backoff without any random jitter causes the concurrent instances to attempt the block allocation at the same intervals. Staggering this backoff with a random jitter (ExponentialBackoff.java) allows competing instances to properly secure the resources required for block allocation.