Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 435: Filter gene-related disorder submission from curation and evidence generation #443

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

apriltuesday
Copy link
Contributor

@apriltuesday apriltuesday commented Sep 5, 2024

Closes #435

@apriltuesday apriltuesday changed the title Issue 435 2 Issue 435: Filter gene-related disorder submission from curation and evidence generation Sep 5, 2024
@apriltuesday apriltuesday self-assigned this Sep 5, 2024
@apriltuesday apriltuesday marked this pull request as ready for review September 5, 2024 14:43
@apriltuesday
Copy link
Contributor Author

I'm running a test spreadsheet creation to check the output, but meanwhile the code can be reviewed.

@apriltuesday
Copy link
Contributor Author

Spreadsheet from the test is here. The gene-related disorder terms are certainly not gone (though there are about 2000 fewer terms total compared to July), but their frequency in ClinVar is much reduced so they are deprioritised. I spot-checked a couple terms to make sure they were indeed present in other submissions besides the one filtered out.

@apriltuesday apriltuesday merged commit 269479e into EBIvariation:master Sep 9, 2024
1 check passed
@apriltuesday apriltuesday deleted the issue-435_2 branch September 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter generic gene-related condition terms from manual curation and evidence string generation
2 participants