fix: added a better sizing on icons

EAVFW · Aug 28, 2024 · 8746369 · 8746369
1 parent 6992f5e
commit 8746369
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/packages/core/src/components/renderers/slide-renderer/SlideRenderer.tsx b/packages/core/src/components/renderers/slide-renderer/SlideRenderer.tsx
@@ -51,7 +51,7 @@ export const SlideRenderer: React.FC = () => {
                 showPressEnter={showPressEnter}
                 children={
                     <>
-                        {currentSlide?.buttonText}<IconResolver type={currentSlide?.icon ?? state.defaultSlideButtonIcon} style={{ height: '100%', marginLeft: quickformtokens.gap1 }} color={quickformtokens.onPrimary} size={20} />
+                        {currentSlide?.buttonText}<IconResolver type={currentSlide?.icon ?? state.defaultSlideButtonIcon} style={{ display:"flex", height: quickformtokens.slideButtonIconSize, width: quickformtokens.slideButtonIconSize, marginLeft: quickformtokens.gap1 }} color={quickformtokens.onPrimary} size={"100%"} />
                     </>
                 }
             />

diff --git a/packages/core/src/style/defaultQuickFormTokens.ts b/packages/core/src/style/defaultQuickFormTokens.ts
@@ -72,4 +72,6 @@ export const defaultQuickFormTokens: QuickFormTokens = {
     lowEmphasisOpacity: 0.38,
     mediumEmphasisOpacity: 0.60,
     highEmphasisOpacity: 0.87,
+
+    slideButtonIconSize: '1.5rem',
 };
diff --git a/packages/core/src/style/quickFormTokensDefinition.ts b/packages/core/src/style/quickFormTokensDefinition.ts
@@ -67,6 +67,8 @@ type QuickFormTokensBase = {
     questionPadding: string;
     questionInputGap: Gap,
     questionPaddingBottom: string;
+
+    slideButtonIconSize: string;
 };
 
 export type QuickFormTokens = QuickFormTokensBase & {

diff --git a/...s/inputs/select/src/dropdown-options-list/dropdown-select-option/DropdownSelectOption.tsx b/...s/inputs/select/src/dropdown-options-list/dropdown-select-option/DropdownSelectOption.tsx
@@ -62,7 +62,7 @@ export function DropdownSelectOption({
         >
             {children}
             {isSelected && (
-                <Checkmark style={{display:"flex"}} color={quickformtokens.onSurface} size={24} />)}
+                <Checkmark style={{display:"flex"}} color={quickformtokens.onSurface} size={"2rem"} />)}
         </span>
     );
 }