Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default parameters #13

Closed
wants to merge 2 commits into from
Closed

Update default parameters #13

wants to merge 2 commits into from

Conversation

rickecon
Copy link
Collaborator

This PR updates the default parameters, and nothing else. @SeaCelo @jdebacker

@SeaCelo
Copy link
Collaborator

SeaCelo commented Aug 13, 2024

Hey @rickecon

Thanks for the contribution! I see you were working while presenting again, but I’m going to have to give this one a "no-go" for now. The CIT and effective tax rate is probably not relevant to cats. It’s important that we keep the code and documentation focused on actual data, so personal opinions are best left out of the PR.

Let’s keep the good vibes going. Appreciate the effort, and looking forward to your next PR.

Cheers!

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (b3e53e5) to head (066b7b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files          12       12           
  Lines         275      275           
=======================================
  Hits          194      194           
  Misses         81       81           
Flag Coverage Δ
unittests 70.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeaCelo
Copy link
Collaborator

SeaCelo commented Aug 13, 2024

Closed for lack of documentation on the changes to the tax code, and for the opinions on cats in the documentation.

@SeaCelo SeaCelo closed this Aug 13, 2024
@rickecon rickecon deleted the cats branch October 22, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants