add eamxx tests to e3sm suites #6640
Conversation
mahf708
added
Testing
|
mahf708
force-pushed
the
mahf708/ig/eamxx-tests-suites
branch
from
9d1f604
to
956af5d
Compare
|
@mahf708 is this ready? |
yes, we may run into issues once this is on next, but as far as I am concerned, these tests should be passing on all our machines. I will debug if they fail |
|
Question: should we add some/all of the tests that are currently in the various "e3sm_scream" suites to our nightly testing? |
Personally, that's my ultimate goal. I wanted to start with these tests because they are more "traditional" and designed piece by piece with your involvement (in PRs here in this repo). I am happy to add more tests to this PR or issue a separate PR later. I would like @jgfouca and @AaronDonahue to weigh in and see what they prefer :) |
|
Adding more test can wait but I think you should create new suite names in preparation for that. The "atm" suites are really EAM suites. It shouldn't be necessary for an EAM developer to make EAMxx tests pass. (Or should it?). So maybe you should make new e3sm_eamxx_developer, e3sm_eamxx_integration, and e3sm_eamxx_prod suites, add the tests you've already added to those, and then include them in the corresponding e3sm full suites. |
Recall COSP edits led to EAMxx breaking, so at least one test should be run under atm developer. I also thought we were slowly move "atm" from EAM to EAMxx, no? |
|
Good point. If EAMxx depends on code in components/eam then we need an eamxx test. That transition will take years but we need to build up our eamxx testing soon. But new suites can also wait for another PR. |
Adds EAMxx tests to e3sm_atm_developer, e3sm_atm_integration, and e3sm_atm_prod.