-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexing of layers in high freq. output #6497
base: master
Are you sure you want to change the base?
Fix indexing of layers in high freq. output #6497
Conversation
Previously, the layer above the one containing the desired depth was being selected, rather than the layer containing the depth. The default depth if no layer is found is now the deepest layer, rather than the first layer. This is because, if no layer is found, it means that even the deepest layer is shallower than the desired depth, and the only sensible default is the deepest layer.
I successfully ran
With this fix, I'm seeing:
So I do believe the fix is correct and the previous results were incorrect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vanroekel! |
If high-frequency output is in the 3.0 default output, then yes this should wait. |
@rljacob, yes, it is. |
@xylar -- high frequency output is not used in testing BFBness, but it is in the 3.0 default output. So it makes sense to wait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree both based on the logic and your output.
Previously, the layer above the one containing the desired depth was being selected, rather than the layer containing the depth.
The default depth if no layer is found is now the deepest layer, rather than the first layer. This is because, if no layer is found, it means that even the deepest layer is shallower than the desired depth, and the only sensible default is the deepest layer.
non-BFB only for MPAS-Ocean high-frequency output.
Fixes #6496