Add check for invalid fp-ops for GNU in debug mode #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amametjanov
added
enhancement
Machine Files
BFB
|
|
|
I suppose this |
amametjanov
force-pushed
the
azamat/machines/add-gnu-invalid-check
branch
from
7af79a4
to
77c90e6
Compare
amametjanov
commented
Sep 26, 2023
There was a problem hiding this comment.
Rebased onto latest master and re-checked with e3sm_integration: https://my.cdash.org/viewTest.php?buildid=2411304 .
| real(r8), optional, intent(in) :: tropFlagInt(ncol, pver) | ||
| real(r8), optional, intent(in) :: tropFlagInt(pcols, pver) |
There was a problem hiding this comment.
All calls to gaschmmass_diags pass the whole tropFlagInt(:pcols,pver) array.
| mmr_tend(:ncol,:,:), pmid(:ncol,:), pdel(:ncol,:), pdeldry(:ncol,:), pbuf, troplev(:ncol), tropFlag=tropFlag ) | ||
| mmr_tend(:ncol,:,:), pmid, pdel(:ncol,:), pdeldry(:ncol,:), pbuf, troplev, tropFlag=tropFlag ) |
There was a problem hiding this comment.
chm_diags declares pmid and troplev arrays with pcols.
amametjanov
added
non-BFB
rljacob
approved these changes
Oct 12, 2023
amametjanov
added a commit
that referenced
this pull request
Oct 13, 2023
(PR #5808) Add check for invalid fp-ops for GNU in debug mode. Also, fix ncol/pcol indexes in 2 eam-chemistry subroutines (flagged by `-ffpe-trap=invalid`). [non-BFB] - in fully-coupled tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for invalid fp-ops for GNU in debug mode.
Also, fix ncol/pcol indexes in 2 eam-chemistry subroutines
(flagged by
-ffpe-trap=invalid).[non-BFB] - in fully-coupled tests