fix: Acquire lock once outside of sendWithRetries #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/Dynatrace/dynatrace-configuration-as-code-core/blob/main/api/rest/client.go,
func (c *Client) sendWithRetries(...)calls itself recursively, but (tries to) acquire a lock each time. This causes the function to deadlock.Proposed solution is to only acquire this lock once, outside of
sendWithRetries(...).Only issue is that the rate limiter may sleep once it acquires the lock, but as this is shared by all goroutines accessing the client, this should have no impact.